Merged
Conversation
28346df to
103ded9
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the UI/widget set by (1) rewriting the DAP model combobox to behave like other editable comboboxes with validity highlighting, and (2) introducing a new BEC Atlas “Admin View” with an HTTP service and experiment-selection UI (plus tests), alongside a small toolbar utility tweak and shared fuzzy-search helper.
Changes:
- Rewrite
DapComboBoxto inherit fromQComboBox, be editable, and visually indicate invalid entries. - Add BEC Atlas Admin View (HTTP service + experiment selection/card widgets) with comprehensive unit tests.
- Centralize fuzzy-search matching into
bec_widgets.utils.fuzzy_searchand reuse it across widgets; addPyJWTdependency.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit_tests/test_dap_combobox.py | Extends coverage for editable DAP combobox behavior and validity highlighting. |
| tests/unit_tests/test_atlas_admin_view.py | Adds unit tests for the new Atlas HTTP service and Admin View UI logic. |
| pyproject.toml | Adds PyJWT runtime dependency for JWT decoding in the Atlas HTTP service. |
| bec_widgets/widgets/services/bec_atlas_admin_view/experiment_selection/utils.py | Adds formatting/parsing helpers for experiment name and schedule display. |
| bec_widgets/widgets/services/bec_atlas_admin_view/experiment_selection/experiment_selection.py | New experiment selection widget (card + table + filters + fuzzy/exact match). |
| bec_widgets/widgets/services/bec_atlas_admin_view/experiment_selection/experiment_mat_card.py | New “mat-card” style experiment detail widget with activate/change action. |
| bec_widgets/widgets/services/bec_atlas_admin_view/experiment_selection/init.py | Package init for experiment selection submodule. |
| bec_widgets/widgets/services/bec_atlas_admin_view/bec_atlas_http_service.py | New Qt QNetworkAccessManager-based HTTP service for Atlas login/auth + API calls. |
| bec_widgets/widgets/services/bec_atlas_admin_view/bec_atlas_admin_view.py | New Admin View widget integrating toolbar, login/overview, experiment selection. |
| bec_widgets/widgets/services/bec_atlas_admin_view/init.py | Package init for Atlas admin view module. |
| bec_widgets/widgets/dap/dap_combo_box/dap_combo_box.py | Rewrites DAP combobox implementation as an editable QComboBox with validation styling. |
| bec_widgets/widgets/control/device_manager/components/device_table/device_table.py | Replaces duplicated fuzzy matching logic with shared utils.fuzzy_search.is_match. |
| bec_widgets/utils/toolbars/actions.py | Extends create_action_with_text() with optional min_size. |
| bec_widgets/utils/fuzzy_search.py | New shared fuzzy/exact matching helper (is_match). |
| bec_widgets/cli/client.py | Adds RPC stub class for AdminView. |
| bec_widgets/applications/views/admin_view/admin_view.py | Adds application view wrapper around BECAtlasAdminView. |
| bec_widgets/applications/views/admin_view/init.py | Package init for Admin View. |
| bec_widgets/applications/main_app.py | Registers Admin View in the main application sidebar/stack and hardens view switching. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
103ded9 to
be929b4
Compare
be929b4 to
b435f24
Compare
wakonig
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DAP combobox rewritten as inheritance from QComboBox and follow the same logic as device comboboxes with editable True and visual validation indication with red outline if invalid model is choosen.