chore: remove bluesky emitter as it is not used anywhere#799
Open
chore: remove bluesky emitter as it is not used anywhere#799
Conversation
wakonig
force-pushed
the
chore/remove_bluesky_emitter
branch
from
2799898 to
14e4791
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the unused Bluesky emitter integration from the scan bundler, along with its associated per-scan state and tests, to reduce legacy/unused code.
Changes:
- Remove
BlueskyEmitterimplementation and stop initializing it inScanBundler. - Remove
ScanBundler.scan_motorsstate and related initialization/cleanup logic. - Delete Bluesky emitter unit tests and adjust scan bundler tests accordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| bec_server/bec_server/scan_bundler/scan_bundler.py | Stops importing/initializing BlueskyEmitter and removes scan_motors storage usage. |
| bec_server/bec_server/scan_bundler/bluesky_emitter.py | Removes the unused BlueskyEmitter implementation. |
| bec_server/tests/tests_scan_bundler/test_bluesky_emitter.py | Removes tests that only apply to the deleted emitter. |
| bec_server/tests/tests_scan_bundler/test_scan_bundler.py | Updates tests to no longer depend on scan_motors being stored in the bundler. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wakonig
force-pushed
the
chore/remove_bluesky_emitter
branch
from
14e4791 to
1ad993a
Compare
wakonig
force-pushed
the
chore/remove_bluesky_emitter
branch
from
97a5b43 to
1ad993a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can re-add it if we see a use case for it but in its current state it is not very useful and requires some legacy code I'd like to get rid of.