Conversation
d93fb70 to
e7f1f77
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
50975d5 to
ea5bb22
Compare
wakonig
reviewed
Nov 17, 2025
bec_server/bec_server/device_server/devices/config_update_handler.py
Outdated
Show resolved
Hide resolved
1e83293 to
025765e
Compare
Contributor
Author
|
@wakonig I just undid the logging commit, we should maybe discuss it in more detail sometime outside of this PR |
025765e to
5aba36e
Compare
Member
|
@d-perl sorry for the delay. I just tried to run it but it first got stuck and never picked it up. After a restart of the _dev_runner everything was fine. We should have a quick discussion about the logs tomorrow though. I used the companion branch in BW but I wasn't able actually see the scan table from the procedure. |
19f8cf9 to
f3f6e6f
Compare
Member
|
just out of curiosity... could you rebase your branch on main and see if the coverage report is fixed? Also fine if you don't want to do this on this branch ;) |
- add helper for Redis communication - add abort functionality - add removal from aborted queues - add status API - fix bugs in manager to update redis state correctly
f3f6e6f to
cae0c5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds functionality to the procedure manager and associated tooling:
Helpful for testing:
run the
_dev_runner.pyMake sure you have a pod created with
podman pod create --add-host redis:host-gateway local_becIn a bec console:
bec-project/bec_widgets#902 can be used to monitor queues, abort and reschedule procedures, as well as run scripts as procedures