Migrate from roam to vox RPC framework#181
Open
fasterthanlime wants to merge 10 commits into
Open
Conversation
Rename all roam crate dependencies to their vox equivalents (roam→vox, roam-core→vox-core, roam-stream→vox-stream, roam-local→vox-local) at version 0.2.0. Update all Rust source references including: - roam::service → vox::service - roam::RoamError → vox::VoxError - roam::acceptor/initiator → vox::acceptor_on/initiator_on - All transport and local IPC types All 273 tests pass.
Enables filename/line number info in backtraces for release builds without the bloat of full debug info.
Adds ent.plist to xtask and updates the codesign step to include the com.apple.security.get-task-allow entitlement, allowing debuggers and profilers to attach to release builds.
When the subscribe stream broke (daemon/client death), rx.recv() returned Err immediately, bypassing the 500ms timeout and calling version() in a tight loop, leaking memory each time. Now the subscribe channel is recreated each iteration. On stream failure, we fall back to a single version() call with a 250ms sleep before retrying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
roamcrate dependencies to theirvoxequivalents (roam→vox, roam-core→vox-core, roam-stream→vox-stream, roam-local→vox-local) at version 0.2.0roam::service→vox::service,roam::RoamError→vox::VoxError,roam::acceptor/initiator→vox::acceptor_on/initiator_on, and all transport/local IPC typesTest plan
cargo checkcompiles cleanlycxi(full release build + install) succeeds