Skip to content

feat: permit owned iteration over entries#158

Merged
CosmicHorrorDev merged 2 commits into
bearcove:mainfrom
sftse:c-dev
May 9, 2026
Merged

feat: permit owned iteration over entries#158
CosmicHorrorDev merged 2 commits into
bearcove:mainfrom
sftse:c-dev

Conversation

@sftse
Copy link
Copy Markdown
Contributor

@sftse sftse commented Jan 17, 2026

We needed an EntryHandle that owned its reader. This required a fork of rc-zip-sync but it isn't clear if we want to go through the process of upstreaming that patch just yet.

A prerequisite for this is owning the iterator over the entries, so this is the small modification we had to do to rc-zip itself.

Copy link
Copy Markdown
Collaborator

@CosmicHorrorDev CosmicHorrorDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! im definitely interested in exploring an an owned EntryHandle (there's been a few open PRs for it, just been busy 😮‍💨)

Comment thread rc-zip/src/parse/archive.rs Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.97%. Comparing base (504411f) to head (08fc72f).

Files with missing lines Patch % Lines
rc-zip/src/parse/archive.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   77.95%   77.97%   +0.02%     
==========================================
  Files          27       27              
  Lines        2708     2711       +3     
  Branches      134      134              
==========================================
+ Hits         2111     2114       +3     
  Misses        528      528              
  Partials       69       69              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CosmicHorrorDev CosmicHorrorDev added this pull request to the merge queue May 9, 2026
Merged via the queue into bearcove:main with commit 4c0ff8d May 9, 2026
4 of 5 checks passed
@sftse sftse deleted the c-dev branch May 12, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants