feat: permit owned iteration over entries#158
Merged
Conversation
CosmicHorrorDev
approved these changes
May 5, 2026
Collaborator
CosmicHorrorDev
left a comment
There was a problem hiding this comment.
looks good to me! im definitely interested in exploring an an owned EntryHandle (there's been a few open PRs for it, just been busy 😮💨)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 77.95% 77.97% +0.02%
==========================================
Files 27 27
Lines 2708 2711 +3
Branches 134 134
==========================================
+ Hits 2111 2114 +3
Misses 528 528
Partials 69 69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We needed an
EntryHandlethat owned its reader. This required a fork ofrc-zip-syncbut it isn't clear if we want to go through the process of upstreaming that patch just yet.A prerequisite for this is owning the iterator over the entries, so this is the small modification we had to do to
rc-zipitself.