Fix get_section ordering and subsection shape in template context#252
Open
Dekker1 wants to merge 1 commit into
Open
Fix get_section ordering and subsection shape in template context#252Dekker1 wants to merge 1 commit into
get_section ordering and subsection shape in template context#252Dekker1 wants to merge 1 commit into
Conversation
Re-using the `section_to_value` function in `template_host` that was defined and used in `render`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an inconsistency between the normal page/section template context and the
get_section(...)template helper.Currently,
get_section(...)built its own reduced section value intemplate_host.rs. In this version, I found two problems:pageswere returned in route order instead ofweightordersubsectionswere returned as path strings rather than full section objects, so template-side sorting byweightcould not workThis patch makes
get_section(...)reuse the existingsection_to_value(...)serializer fromrender.rs, which is already the canonical section representation used elsewhere.