Issue #4 - Move to stub/mock based testing.#5
Open
jesseward wants to merge 1 commit intobcicen:masterfrom
Open
Issue #4 - Move to stub/mock based testing.#5jesseward wants to merge 1 commit intobcicen:masterfrom
jesseward wants to merge 1 commit intobcicen:masterfrom
Conversation
The currently library is strongly coupled HA-Proxy, meaning that
in order to execute tests haproxy must be running locally. This
change adds an interface (HAProxy) that allows us to then stub out
the calls to RunCommand.
Note: If you're to go this route, README will need to be updated as
the Info and Stats methods are no longer pointer receivers, but instead
receiving the HAProxyClient as an argument. For example
client := HAProxyClient{Addr: "tcp://blah:64738"}
info, err := Info(client) {
...
}
...
|
|
||
| // Equivalent to HAProxy "show info" command. | ||
| func (h *HAProxyClient) Info() (*Info, error) { | ||
| func Info(h HAProxy) (*InfoResponse, error) { |
There was a problem hiding this comment.
This is a breaking change to the existing API. It may be trivial but is worth noting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The currently library is strongly coupled HA-Proxy, meaning that in order to execute tests haproxy must be running locally. This change adds an interface (HAProxy) that allows us to then stub out the calls to RunCommand.
Note: If you're to go this route, README will need to be updated as the Info and Stats methods are no longer pointer receivers, but instead receiving the HAProxyClient as an argument. For example
Your method (or implementation) may vary. Though as @benjic mentioned, decoupling network services from your test cases are the way to go.