Added deadline timeout for socket operations (avoid deadlocks)#12
Open
vponomarev wants to merge 2 commits intobcicen:masterfrom
Open
Added deadline timeout for socket operations (avoid deadlocks)#12vponomarev wants to merge 2 commits intobcicen:masterfrom
vponomarev wants to merge 2 commits intobcicen:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation will be blocked forever in case if haproxy (or someone else, opened this socket) will not generate any answer and will not close socket.
So, the fix is:
I tested with fake haproxy running by:
socat - UNIX-LISTEN:./var/run/haproxy.sockOld implementation was blocked, new implementation returned after timeout:
read unix ->/var/run/haproxy.sock: i/o timeout