Skip to content

Conversation

@emi-hi
Copy link
Collaborator

@emi-hi emi-hi commented Mar 31, 2025

No description provided.

@emi-hi emi-hi requested a review from tim738745 March 31, 2025 22:05
@sonarqubecloud
Copy link

Copy link
Collaborator

@tim738745 tim738745 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emi-hi looks good to me! Just want to make sure I understand how this script was used:

(1) The compare_csvs function was run 21 times - once for each ICBC file, and each time the file was compared with the same output file generated from the SQL in the first cell.

(2) Each vin in the collection of 109 additional vins comes from at least one of the comparison instances, not necessarily every one of the comparison instances. For example, if vin X is not in our current icbc registration data, it is in the 2022-01-31 file, and it is not in the 2022-08-31 file, then vin X would be a member of the 109 vins?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants