Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMI-3203 use vitest #2421

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

MMI-3203 use vitest #2421

wants to merge 10 commits into from

Conversation

JacobWang-bc
Copy link
Collaborator

@JacobWang-bc JacobWang-bc commented Mar 11, 2025

initial test for use of vitet, see FRONTEND-TEST.md for details.

@JacobWang-bc JacobWang-bc added documentation Improvements or additions to documentation editor subscriber PR contains changes towards the subscriber application, unit tests Unit tests for the application. labels Mar 11, 2025
Copy link
Collaborator

@Fosol Fosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very happy to finally see this!

@@ -64,8 +64,9 @@
},
"devDependencies": {
"@simbathesailor/use-what-changed": "2.0.0",
"@testing-library/jest-dom": "6.4.5",
"@testing-library/jest-dom": "^6.6.3",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always fix your versions in your final release. Otherwise each environment may have different versions.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I will change later. I will rebase from Nehal as well.

@JacobWang-bc
Copy link
Collaborator Author

I will update cache files after approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation editor subscriber PR contains changes towards the subscriber application, unit tests Unit tests for the application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants