30614 Add expiration date validation to edit#1583
Merged
eve-git merged 2 commits intobcgov:mainfrom Nov 27, 2025
Merged
Conversation
eve-git
requested review from
mengdong19,
ozamani9gh,
rarmitag,
shaangill025 and
stevenc987
as code owners
eve-git
commented
Nov 26, 2025
| <LoadingSpinner v-if="search.isLoading" /> | ||
| </div> | ||
|
|
||
| <PopupDialog :show="showDateDialog"> |
Collaborator
Author
There was a problem hiding this comment.
fixed the warning:
cannot be child of , according to HTML specifications. This can cause hydration errors or potentially disrupt future functionality.
eve-git
commented
Nov 26, 2025
| optionsDisplay: (option: any) => option, | ||
| } | ||
| ) | ||
| }>() |
Collaborator
Author
There was a problem hiding this comment.
Fixed the warning: withDefaults() is unnecessary when using destructure with defineProps().
eve-git
commented
Nov 26, 2025
| <LoadingSpinner v-if="isLoading" /> | ||
| </div> | ||
|
|
||
| </div> |
Collaborator
Author
There was a problem hiding this comment.
Fixed the warning:
cannot be child of , according to HTML specifications. This can cause hydration errors or potentially disrupt future functionality.
Collaborator
Author
|
/gcbrun |
|
Temporary Url for review: https://namex-dev--pr-1583-67s66qmy.web.app |
hfekete
approved these changes
Nov 27, 2025
Collaborator
hfekete
left a comment
hfekete
left a comment
There was a problem hiding this comment.
Looks good!
There is one comment, please check it and see if you want to act on it.
app/components/search/ResultsBox.vue
Outdated
| </table> | ||
|
|
||
| <div class="absolute bottom-1/2 right-1/2 translate-x-1/2 translate-y-1/2 transform"> | ||
| <LoadingSpinner v-if="search.isLoading" /> |
Collaborator
There was a problem hiding this comment.
you could try moving the v-if="search.isLoading" in the div above:
<div v-if="search.isLoading" class=absolute...
I think it should work, and entire div would be out of the page when loading is not set to true.
Otherwise, div is there, though probably of size 0 or 1px or smth like that.
But if this works, and that div is not in the way of the page it can stay.
app/pages/Stats.vue
Outdated
| </div> | ||
| </table> | ||
| <div class="absolute bottom-1/2 right-1/2 translate-x-1/2 translate-y-1/2 transform"> | ||
| <LoadingSpinner v-if="isLoading" /> |
Collaborator
There was a problem hiding this comment.
same as above for the v-if
Collaborator
Author
|
/gcbrun |
|
Temporary Url for review: https://namex-dev--pr-1583-67s66qmy.web.app |
hfekete
added a commit
that referenced
this pull request
Jan 22, 2026
* test github app (#1578) - verify pre-view build workflow using github app instead of token * 31118 bug fix: SUBMITTED DATE SORT does not work (#1581) * bug fix: SUBMITTED DATE SORT does not work * order on submitted date only * 30614 Add expiration date validation to edit (#1583) * add expiration date validation to edit * update * 31568 - Chore: remove broken link (#1584) * 31568 - Chore: remove broken link * 31569 - Test: update search test to match current order criteria --------- Co-authored-by: Andrew Bolyachevets <Andriy.Bolyachevets@gov.bc.ca> Co-authored-by: eve-git <54647458+eve-git@users.noreply.github.com>
hfekete
added a commit
that referenced
this pull request
Jan 27, 2026
* test github app (#1578) - verify pre-view build workflow using github app instead of token * 31118 bug fix: SUBMITTED DATE SORT does not work (#1581) * bug fix: SUBMITTED DATE SORT does not work * order on submitted date only * 30614 Add expiration date validation to edit (#1583) * add expiration date validation to edit * update * 31568 - Chore: remove broken link (#1584) * 31568 - Chore: remove broken link * 31569 - Test: update search test to match current order criteria * Name Examination UI: change to use Namex API GW URL and API key#30767 Signed-off-by: stevenc987 <steven.chen@gov.bc.ca> * Name Examination UI: change to use Namex API GW URL and API key#30767 Signed-off-by: stevenc987 <steven.chen@gov.bc.ca> * Refactor: improve highlighting logic and modularize with `highlightWord` utility function --------- Signed-off-by: stevenc987 <steven.chen@gov.bc.ca> Co-authored-by: Andrew Bolyachevets <Andriy.Bolyachevets@gov.bc.ca> Co-authored-by: eve-git <54647458+eve-git@users.noreply.github.com> Co-authored-by: stevenc987 <steven.chen@gov.bc.ca>
hfekete
added a commit
that referenced
this pull request
Feb 3, 2026
* test github app (#1578) - verify pre-view build workflow using github app instead of token * 31118 bug fix: SUBMITTED DATE SORT does not work (#1581) * bug fix: SUBMITTED DATE SORT does not work * order on submitted date only * 30614 Add expiration date validation to edit (#1583) * add expiration date validation to edit * update * 31568 - Chore: remove broken link (#1584) * 31568 - Chore: remove broken link * 31569 - Test: update search test to match current order criteria * Name Examination UI: change to use Namex API GW URL and API key#30767 Signed-off-by: stevenc987 <steven.chen@gov.bc.ca> * Name Examination UI: change to use Namex API GW URL and API key#30767 Signed-off-by: stevenc987 <steven.chen@gov.bc.ca> * Refactor: improve highlighting logic and modularize with `highlightWord` utility function * 31278-Update code owners. (#1588) * Chore: remove unused `backup-pnpm-lock.yaml.backup` file updated plugins to return names Fix tests to run locally * reverted some changes in plugins * Fix: remove duplicate `LoadingSpinner` component in `ResultsBox.vue` * Test: add Vue Router setup to test configuration * Chore: update `happy-dom` to version 20.4.0 in `pnpm-lock.yaml` and dependencies (dealing with vulnerabilities in v14) * Chore: update Node.js to v24, configure module type, and improve typings and event handling * chore: upgrade cloud build to node 24 & pnpm * chore: add pnpm version 10.28.1 and node version 24.x to CI/CD workflows * chore: remove unused `@vitejs/plugin-vue` dependency from package.json * missing pnpm-lock.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #:
https://app.zenhub.com/workspaces/names-team-board-new-655554cbddd49510027dad2e/issues/gh/bcgov/entity/30614
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).