26502 calls to namex api include app-name header#1576
Merged
EPortman merged 2 commits intobcgov:mainfrom Jun 11, 2025
Merged
Conversation
EPortman
requested review from
eve-git,
flutistar,
mengdong19,
ozamani9gh,
rarmitag,
shaangill025 and
stevenc987
as code owners
Contributor
Author
|
/gcbrun |
EPortman
changed the title
Collaborator
|
Temporary Url for review: https://namex-dev--pr-1576-n95itmrr.web.app |
stevenc987
approved these changes
Jun 11, 2025
Contributor
Author
|
/gcbrun |
Collaborator
|
Temporary Url for review: https://namex-dev--pr-1576-rv6pru95.web.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*Issue #: bcgov/entity#26502
Description of changes:
Calls to NameX API include app-name header.
callNamexApimethod. So the app-name was added here which was retrieved from the package.json filecallNamexApi, so that was changed to make it so that it does for consistency.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).