Business API - correction updates to support relationships schema and…#4148
Business API - correction updates to support relationships schema and…#4148kialj876 wants to merge 5 commits intobcgov:mainfrom
Conversation
… liquidators/receivers, liquidator tweaks Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
There was a problem hiding this comment.
why do we need this change? I thought we are not syncing receivers and liquidators https://github.com/bcgov/lear/blob/main/legal-api/src/legal_api/models/filing.py#L1328
There was a problem hiding this comment.
We need it because corrections are synced back to colin and they may have receivers or liquidators inside. Since corrections can technically update anything (i.e. I could have updates to directors, receivers and liquidators in a single correction) this will ensure the receivers and liquidators changes are not sent back to colin. If only updates to liquidators or receivers were made then it will not send the filing back to colin.
It also supports correction updates to directors using the relationships schema (the new corrections UI will do this)
There was a problem hiding this comment.
- what happens if the correct has only receivers or liquidators change? which means no data to sync
- if directors using relationship then output must support both parties and relationship. right?
There was a problem hiding this comment.
- Correct no data to sync so it will not pick up the filing in the get_colin_filings_to_sync call and secured it with a unit test (COR / COL are corrections to receivers and liquidators only)
- Good point - I will take a look at that and see what changes I need to add
There was a problem hiding this comment.
Okay I updated the outputs in the least impactful way I could think of so that it doesn't complicate things too much - let me know what you think
There was a problem hiding this comment.
The only concern I have is the performance issue if prod has a lot of correction specific to receivers or liquidators change. Until now filings which are not required to sync is excluded in the query itself.
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
|
2 participants
… liquidators/receivers, liquidator tweaks
Issue #: /bcgov/entity#32670 , bcgov/entity#32565
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).