Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Practice migration: set purpose for reg 1 ops with boro id #2889

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

BCerki
Copy link
Contributor

@BCerki BCerki commented Feb 20, 2025

card: https://github.com/orgs/bcgov/projects/123/views/16?pane=issue&itemId=97842660&issue=bcgov%7Ccas-registration%7C2841

This PR:

  • migration to set purpose for reg1 records
  • see Task/migrate operation reg1 statuses/2770 #2868 for testing instructions (steps 1-4 exactly the same, and then run migrations incrementally if desired)
  • this doesn't require any update to the mock data or any other parts of the app, so no AC added to the ticket for the real migration

Copy link
Contributor

@andrea-williams andrea-williams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Informally approved - not going to actually Approve it just to ensure that this doesn't get merged into develop prematurely.

Have confirmed it works as described in the ticket AC. Had a horrible thought while looking at the prod data - we have the opt_in boolean flag and I know at some point we were talking about setting the purpose for those to "Opted-In" by default but I can't remember whether we actually agreed to that or not. I'll check with Patricia.

Also, minor nit: could you please rename the "auto_blah" migration filename to a better descriptor?

@BCerki
Copy link
Contributor Author

BCerki commented Feb 24, 2025

Informally approved - not going to actually Approve it just to ensure that this doesn't get merged into develop prematurely.

Have confirmed it works as described in the ticket AC. Had a horrible thought while looking at the prod data - we have the opt_in boolean flag and I know at some point we were talking about setting the purpose for those to "Opted-In" by default but I can't remember whether we actually agreed to that or not. I'll check with Patricia.

Also, minor nit: could you please rename the "auto_blah" migration filename to a better descriptor?

Per Teams conversation, if the opt-in flag is True, we'll set the purpose to Opted-In instead of OBPS Regulated

@andrea-williams
Copy link
Contributor

re-approved! Thanks Bri!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants