BRD - access business password error flow update#397
Open
kialj876 wants to merge 2 commits intobcgov:mainfrom
Open
BRD - access business password error flow update#397kialj876 wants to merge 2 commits intobcgov:mainfrom
kialj876 wants to merge 2 commits intobcgov:mainfrom
Conversation
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
kialj876
requested review from
JazzarKarim and
severinbeauvais
as code owners
Collaborator
Author
|
/gcbrun |
Collaborator
|
Temporary Url for review: https://business-registry-dev--pr-397-u9t11gpe.web.app |
deetz99
approved these changes
Feb 20, 2026
web/business-registry-dashboard/app/components/Form/AddBusiness/Base.vue
Show resolved
Hide resolved
| required: 'Password is required', | ||
| length: 'Password must be 8 to 15 characters' | ||
| length: 'Password must be 8 to 15 characters', | ||
| api: 'Password error, please try again or choose an option below | Password error, please try again' |
Collaborator
There was a problem hiding this comment.
These are run-on sentences (poor grammar). Please ask UX about them (and also line 353).
Collaborator
Author
There was a problem hiding this comment.
sure I'll ask them about it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#32497
Description of changes:
examples:
Coops
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).