32323 plugin share structure to transition#394
Conversation
|
/gcbrun |
|
Temporary Url for review: https://business-registry-home-dev--pr-394-76xcxnsq.web.app |
|
Temporary Url for review: https://business-corps-dev--pr-394-94qlxtlf.web.app |
|
Temporary Url for review: https://business-people-dev--pr-394-ljyocsk7.web.app |
| // Still needed? | ||
| // export interface ShareStructure { | ||
| // resolutionDates?: string[] | ||
| // valid?: boolean | ||
| // changed?: boolean | ||
| // shareClasses: ShareClass[] | ||
| // } |
There was a problem hiding this comment.
Maybe not, if commented?
| @@ -0,0 +1,29 @@ | |||
| export function formatShareClassesUi( | |||
| classes: ShareClass[] | |||
| // config = 'table' // add other format config as necessary | |||
There was a problem hiding this comment.
For future reference?
| getBusinessAddressesMock(), | ||
| 'STAFF' | ||
| ) | ||
| await page.route(`**/api/v2/businesses/${identifier}/share-classes`, async (route) => { |
There was a problem hiding this comment.
add this into mockCommonApiCallsForFiling?
| await expect(page.getByTestId('share-structure-section')).toBeVisible() | ||
| // has articles | ||
| await expect(page.getByTestId('articles-section')).toBeVisible() | ||
| await assertCorrectShareStructure(page) |
There was a problem hiding this comment.
add to client test as well? Maybe better if the client / staff were in a for each like the DOD tests
There was a problem hiding this comment.
oops yeah I forgot to add here
This is in the common assertion helper so it is in the client test already
|
/gcbrun |
|
Temporary Url for review: https://business-registry-home-dev--pr-394-76xcxnsq.web.app |
|
Temporary Url for review: https://business-corps-dev--pr-394-94qlxtlf.web.app |
|
Temporary Url for review: https://business-people-dev--pr-394-ljyocsk7.web.app |
4 participants
Issue #: /bcgov/entity#32323
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).