Skip to content

Conversation

@TimCsaky
Copy link
Contributor

@TimCsaky TimCsaky commented May 2, 2025

Description

MVP implementation of public folders that can be accessed without login:

  • "My Objects" page (i.e. the one displaying folder contents):
    • Now accessible without login, as long as the folder is public
    • Label indicating that a folder is public, appended next to the folder name
    • Individual object public toggles are disabled if the folder is public
  • "My files" page (i.e. the one that displays all the folders)
    • Labels indicating whether a folder is public
  • Bucket permissions modal
    • New toggle for changing whether a folder is public (or not)
      • This toggle is disabled if the parent folder is public

The following items have been skipped over for now:

  • "File details" sidebar/view; for now:
    • The associated action button has been hidden
    • The link on the filename duplicates the functionality of the "download" button
  • CSS for the bucket public toggle
    • The toggle "switch" is off-centre, but otherwise still perfectly functional

SHOWCASE-3959
SHOWCASE-3960

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions
Copy link

github-actions bot commented May 2, 2025

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

@github-actions
Copy link

github-actions bot commented Sep 17, 2025

Coverage Report (Frontend)

Totals Coverage
Statements: 16.06% ( 857 / 5337 )
Methods: 16.43% ( 161 / 980 )
Lines: 19.74% ( 574 / 2908 )
Branches: 8.42% ( 122 / 1449 )

@github-actions
Copy link

github-actions bot commented Sep 17, 2025

Copy link
Contributor Author

@TimCsaky TimCsaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i forgot to submit these comments about 5 months ago.

remove old views for a public folder feature
- move auto-sync to ObjectList, added nicer sync status
- add action buttons to folder view
- filter action buttons for subfolders
- change panel headers
- wording changes
Disable checkbox if permission is set on parent folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants