Skip to content

feat: updated conditions filter logic to accurately filter results#1037

Merged
JazzarKarim merged 5 commits intobcgov:mainfrom
JazzarKarim:32371-filter-logic-update-exact-matches
Feb 19, 2026
Merged

feat: updated conditions filter logic to accurately filter results#1037
JazzarKarim merged 5 commits intobcgov:mainfrom
JazzarKarim:32371-filter-logic-update-exact-matches

Conversation

@JazzarKarim
Copy link
Collaborator

@JazzarKarim JazzarKarim commented Feb 12, 2026

Issue:

Description of changes:

  • PR only:
image
  • BL only:
image
  • PR + BL:
image
  • I tested my changes in the registrations table as well, they work.

  • I also compared results with what we already had in DEV, the numbers check out:
    When I select PR in DEV, I get 543 results.
    In here with my new changes:

    • When I select PR only, I get 274 results
    • When I select PR + BL, I get 269 results
      274 + 269 = 543 which makes sense. Just some fun math here to verify results 😁
  • Did some refactoring to the code to fix the Cognitive Complexity issue reported by SC:

image

Ignore the above, new requirements have been set:

• Selecting BL should return only records with value 'BL' and 'BL + PR'
• Selecting PR should return only records with value 'PR' and 'BL + PR'
• Selecting BL, PR should return all records with values 'BL', 'PR', and 'BL + PR'

Implemented the above

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

@JazzarKarim JazzarKarim self-assigned this Feb 12, 2026
@JazzarKarim JazzarKarim marked this pull request as ready for review February 12, 2026 23:19
Copy link
Collaborator

@thorwolpert thorwolpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, and decent changes on the tests!

@dimak1
Copy link
Collaborator

dimak1 commented Feb 15, 2026

@JazzarKarim we going to hold off the merge until we the release right?

@JazzarKarim
Copy link
Collaborator Author

@JazzarKarim we going to hold off the merge until we the release right?

Yep, I'm not merging until after release

@JazzarKarim JazzarKarim force-pushed the 32371-filter-logic-update-exact-matches branch from 3f7a987 to ad7c9c4 Compare February 19, 2026 22:09
@sonarqubecloud
Copy link

@JazzarKarim JazzarKarim merged commit b92a765 into bcgov:main Feb 19, 2026
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants