[COMP-751][COMP-752]: System Reports#716
Merged
tom0827 merged 4 commits intobcgov:system_reportsfrom Feb 17, 2026
Merged
Conversation
tom0827
requested review from
Ckoelewyn,
danieltruong,
marklise and
tolkamps1
as code owners
tolkamps1
requested changes
Feb 9, 2026
|
|
||
| def generate(self): | ||
| """CEB Summary Report Generation Logic.""" | ||
| projects = TrackService.get_projects() |
Collaborator
There was a problem hiding this comment.
I think this needs to be done slightly differently if you want to get the projects first from the TrackService. The project name associated with each inspection/complaint is the project name at the time the case file was created, this date needs to be passed to the get_projects() in as_of_date to get the name in special history. Or you can re-query the service to get the historic name on line 341 and pass the case file date there.
tolkamps1
approved these changes
Feb 17, 2026
tom0827
added a commit
that referenced
this pull request
Feb 23, 2026
* [COMP-751][COMP-752]: System Reports (#716) * COMP-752 System Reports * COMP-752 fetch projects from track using special history * [Comp-750] Project Compliance report (#738) * [Comp-753] First nations report (#744) * adding case file number column ad hiding report frontend (#753) --------- Co-authored-by: Shaelyn Tolkamp <46355612+tolkamps1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.