Fix/validation - #2206
Closed
SoLetsDev wants to merge 13 commits into
Closed
Conversation
…d breadcrumb on page
…r certification will prevent user from applying for a one year certification
… for first time applicants to Labour Mobility
Stories/ecer 5359
…nto release/labour-mobility
…he upgradable path between a 5 year upgrade or a one year certification
ecer-5359 cleaning up logic. We don't have a situation where we hit t…
…s if someone inputs a non-guid input to a query param
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request Template
about: Template for creating pull requests
Title
confirmed unit tests still pass
testing with bruno passing in non-guid attributes
this came about when I noticed zap scans were triggering 500 errors in our application instead of a bad request
--- End of stack trace from previous location ---
at Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddlewareImpl.g__Awaited|10_0(ExceptionHandlerMiddlewareImpl middleware, HttpContext context, Task task)
[01:07:05 ERR Serilog.AspNetCore.RequestLoggingMiddleware] HTTP GET /api/postSecondaryInstitutionList/id?name=ZAP&provinceId=%22%2F%3E%3Cxsl%3Avalue-of+select%3D%22system-property%28%27xsl%3Avendor%27%29%22%2F%3E%3C%21--&status=Active responded 500 in 3.3930 ms
Description
Related Jira Issue(s)
Checklist
Screenshots (if applicable)
Include screenshots to demonstrate the changes visually.
Additional Comments (optional)
Any additional context or information that might be helpful for the reviewer.