Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WORLDSERVICE369 - Reverb Batch 5 rollout - Zhongwen, Japanese, Hausa [DNM] #12512

Open
wants to merge 10 commits into
base: latest
Choose a base branch
from
+6 −2
Open

WORLDSERVICE369 - Reverb Batch 5 rollout - Zhongwen, Japanese, Hausa [DNM] #12512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5d477b7
add zhongwen reverb config
pvaliani Mar 13, 2025
bf40774
add japanese, update zhongwen
pvaliani Mar 13, 2025
aecf1fd
add hausa
pvaliani Mar 13, 2025
a050f95
add reverb usage to hausa e2es for atianalytics
pvaliani Mar 13, 2025
36a9f58
Merge branch 'latest' into WORLDSERVICE-369-reverb-rollout-batch-5
pvaliani Mar 13, 2025
1527ed5
update tests
pvaliani Mar 13, 2025
e79d1de
Merge branch 'latest' into WORLDSERVICE-369-reverb-rollout-batch-5
pvaliani Mar 13, 2025
ae42b07
Merge branch 'latest' into WORLDSERVICE-369-reverb-rollout-batch-5
pvaliani Mar 13, 2025
8cc21c4
add test coverage on test
pvaliani Mar 13, 2025
8390073
Merge branch 'WORLDSERVICE-369-reverb-rollout-batch-5' of github.com:…
pvaliani Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cypress/e2e/specialFeatures/atiAnalytics/index.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,12 @@ const canonicalTestSuites = [
},
{
path: '/hausa/bbc_hausa_radio/liveradio',
runforEnv: ['local', 'live'],
runforEnv: ['local', 'test', 'live'],
service: 'hausa',
pageIdentifier: 'hausa.bbc_hausa_radio.liveradio.page',
applicationType: 'responsive',
contentType: 'player-live',
useReverb: true,
tests: [
assertPageView,
assertRadioScheduleComponentView,
Expand Down Expand Up @@ -214,6 +215,7 @@ const canonicalTestSuites = [
pageIdentifier: 'hausa.articles.cw43vy8zdjvo.page',
applicationType: 'responsive',
contentType: 'article-sfv',
useReverb: true,
tests: [
assertPageView,
assertLatestMediaComponentView,
Expand Down
1 change: 0 additions & 1 deletion src/app/components/ATIAnalytics/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,7 +1112,6 @@ describe('ATI Analytics Container', () => {
isAmp: false,
pageData: articleDataNews,
pageType: ARTICLE_PAGE,
service: 'hausa', // this is a temporary fix for this unit test failing as this service will have reverb enabled in the last batch
isUK: true,
});

Expand Down
1 change: 1 addition & 0 deletions src/app/lib/config/services/hausa.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export const service: DefaultServiceConfig = {
atiAnalyticsAppName: 'news-hausa',
atiAnalyticsProducerId: '51',
atiAnalyticsProducerName: 'HAUSA',
useReverb: true,
chartbeatDomain: 'hausa.bbc.co.uk',
brandName: 'BBC News Hausa',
product: 'BBC News',
Expand Down
1 change: 1 addition & 0 deletions src/app/lib/config/services/japanese.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export const service: DefaultServiceConfig = {
atiAnalyticsAppName: 'news-japanese',
atiAnalyticsProducerId: '56',
atiAnalyticsProducerName: 'JAPANESE',
useReverb: true,
chartbeatDomain: 'japanese.bbc.co.uk',
brandName: 'BBCニュース',
product: 'BBC News',
Expand Down
1 change: 1 addition & 0 deletions src/app/lib/config/services/zhongwen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const baseServiceConfig = {
atiAnalyticsAppName: 'news-zhongwen',
atiAnalyticsProducerId: '38',
atiAnalyticsProducerName: 'CHINESE',
useReverb: true,
chartbeatDomain: 'zhongwen.bbc.co.uk',
brandName: 'BBC News 中文',
product: 'BBC News',
Expand Down
Loading