Cypress-tests-transliteration-script-switching #12500
Conversation
…tests-transliteration-script-switching
…tests-transliteration-script-switching
…tests-transliteration-script-switching
…tests-transliteration-script-switching
…tests-transliteration-script-switching
MeriemMechri
changed the title
|
We can fix the broken integration tests by running |
| @@ -21,6 +21,7 @@ Object.keys(config) | |||
| .filter( | |||
| pageType => | |||
| serviceHasPageType(serviceId, pageType) && | |||
| pageType !== 'onDemandAudio' && | |||
There was a problem hiding this comment.
Should we also remove the routes from the main settings.js file?
There was a problem hiding this comment.
Also, did we plan to refactor how the tests run to be more like this: #12364?
| @@ -22,20 +23,25 @@ export const clickScriptSwitcher = variant => { | |||
| cy.get(`a[data-variant="${variant}"]`).click(); | |||
| }; | |||
|
|
|||
| export const clickHomePageLink = product => { | |||
| // ToDo: double check this method is not used elsewhere | |||
There was a problem hiding this comment.
Do we need this comment?
| // ToDo: double check this method is not used elsewhere |
| clickFirstLink(); | ||
| } | ||
| }); | ||
| // If it is a MAP test, find first MAP within a StoryPromoLi item and click it |
There was a problem hiding this comment.
| // If it is a MAP test, find first MAP within a StoryPromoLi item and click it | |
| // If it is a MAP test, find first MAP on the homepage and click it |
| // cy.get('header[role="banner"]').first().within(() => { | ||
| // cy.get(`a[data-variant="${scriptToSwitchTo}"]`).should('exist'); |
There was a problem hiding this comment.
Can we put these back now?
| @@ -44,7 +44,7 @@ const defaultCyrillicConfig = { | |||
| datetimeLocale: `uz`, | |||
| externalLinkText: ', ташқи', | |||
| frontPageTitle: 'Бош саҳифа', | |||
| lang: `uz-Cyrl`, | |||
| lang: `uz-cyrl`, | |||
There was a problem hiding this comment.
Do we need to check with anyone (Product?) whether this is OK to change?
|
When I run the tests against test, one of the tests has a problem where when it is looking for the first 
So we need to work out a fix for this for it to not fail in the test e2es. |
|
When I ran the tests locally and on test I noticed that (like we were talking about this morning) the article pages clicked on locally always go to an error page, and then the script switch tests run on the error page. They are then not failing because the test then just checks the script switch works, and it does work on error pages, but it means locally and on test it is not testing article pages work with the script switch, just a lot of error page tests! However, on live it does click valid article pages, and so the tests do run on article pages on live. Do we mind that article pages are not having the script switch checked on local and test, as long as they are covered on live? |
I also ran against live and had the same issue BUT I realised this only happens the first time I run the tests. The next time I run the tests it doesn't happen (probably related to the cookie banner behaviour beign different after first visit). So the question is will this accidential cookie banner click happen in the AWS E2E runs, or not? Does this make the test flakey or does it never do this 🤔 |
Resolves JIRA [WORLDSERVICE-106]
Overall changes
Testing
PR checks passing
Smoke Tests passing on test: CYPRESS_APP_ENV=test yarn cypress:interactive
Smoke Tests passing on live: CYPRESS_APP_ENV=live yarn cypress:interactive
Non-Smoke Tests (Scheduled E2Es) passing on test: CYPRESS_SMOKE=false CYPRESS_APP_ENV=test yarn cypress:interactive
Non-Smoke Tests (Scheduled E2Es) passing on live: CYPRESS_SMOKE=false CYPRESS_APP_ENV=live yarn cypress:interactive
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines