WORLDSERVICE-463: Automated test to ensure local manifest file matches live manifest file for Public Services #12495
+161
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karinathomasbbc
commented
Mar 11, 2025
…0-amp-manifest-file-checker
…0-amp-manifest-file-checker
emilysaffron
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
nice ! assume the tests wont pass here until #12479 is merged right?
Correct! We need to wait for the changes to be live (which also includes the Belfrage PR), so this will sit in Blocked until then 😸 |
amoore108
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA https://jira.dev.bbc.co.uk/browse/WORLDSERVICE-463
Overall changes
Adds an automated test to check that local manifest file matches the live manifest file for PS AMP article pages
Code changes
amp:validatetestsTesting
Please note, these will fail until either #12479 or https://github.com/bbc/belfrage/pull/3779 has been deployed to live