-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WORLDSERVICE 408 - Implement Lite site text CTA under h1 on article page (Gahuza) #12494
Draft
Louis-Matsika
wants to merge
34
commits into
latest
Choose a base branch
from
444-lite-site-cta
base: latest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+150
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to 444-lite-site-cta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA WORLDSERVICE-408
Overall changes
used the existing
CallToActionLink
component to add a CTA button under Article page headingsCode changes
Notes
not done yet, still need to:
Currently these changes effect every heading on a article page (this should be fine as there shouldn't be more than 1
h1
heading on an article page).if work is needed to only apply the CTA under the first heading(as there may be more headings on the page), then work in the
BFF
would need to be done. perhaps adding a custom block that apply'sCallToActionLink
only to the first heading in the data that gets sent off to SimorghTesting
Helpful Links
Coding Standards
Repository use guidelines