Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WORLDSERVICE 408 - Implement Lite site text CTA under h1 on article page (Gahuza) #12494

Draft
wants to merge 34 commits into
base: latest
Choose a base branch
from

Conversation

Louis-Matsika
Copy link
Contributor

@Louis-Matsika Louis-Matsika commented Mar 11, 2025

Resolves JIRA WORLDSERVICE-408

Overall changes

used the existing CallToActionLink component to add a CTA button under Article page headings

Code changes

  • A bullet point list of key code changes that have been made.

Notes

not done yet, still need to:

  • add in translations
  • logic to only render this CTA only on Gahuza(set up + use toggles)
  • Support RTL vs LTR (so that we don't have to do this later once we roll out to more sites)?
  • add view/click tracking to the CTA link
    • use different component name to the existing cta link on lite pages
  • fix some styles
  • update tests
  • add new tests
    • integration test on canonical articles (ensure that the CTA exists)
    • e2e in specialFeatures/atiAnalytics on canonical article for viewing and clicking the CTA
    • e2e in article test for clicking the CTA & navigating to the lite site

Currently these changes effect every heading on a article page (this should be fine as there shouldn't be more than 1 h1 heading on an article page).

if work is needed to only apply the CTA under the first heading(as there may be more headings on the page), then work in the BFF would need to be done. perhaps adding a custom block that apply's CallToActionLink only to the first heading in the data that gets sent off to Simorgh

Testing

  1. List the steps used to test this PR.

Helpful Links

Coding Standards

Repository use guidelines

@Louis-Matsika Louis-Matsika self-assigned this Mar 11, 2025
@Louis-Matsika Louis-Matsika added the enhancement New feature or request label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants