WORLDSERVICE-346 - Remove amp from Homepage regex

[louisearchibald]

Resolves JIRA [346]

Overall changes

Updates the regex for Homepages by removing the .amp segment from the pattern, since we have now removed all amp routes for this pagetype. Amp test files have also been deleted.

Code changes

• Updates getHomePageRegex function to remove any amp references.
• Updates snapshots.
• Removes any homepage amp integration & cypress test files.

[louisearchibald]

Note for reviewers: We have added in this filter logic in order to keep only urls that contain a second forward-slash, excluding homepage url paths from being included in this set of amp tests.

[amoore108]

Open to suggestions on this one from other folk. We can't use pageType here to determine whether or not to run, as 'specialFeatures' / cookie banner tests aren't broken down by page type. If there is a neater way to exclude homepages that would be good!

[amoore108]

@louisearchibald If everyone is happy to keep this logic, I'd add a comment in code above the .filter function to indicate what its intended to do.

[karinathomasbbc]

I have a couple of ideas...

1. add the homepage paths to the urlsToExcludeFromAmpTests array - but we need to be really careful about the value of service here, because it's actually different for the variant services e.g. serbianCyr/ serbianLat rather than serbian - so we need to to extract the serviceName from the config file and use it instead.

So we could do something along the lines of:

const { variant, serviceName } = config[service]; 
const variantPath = variant === 'default' ? '' : `/${variant}`;
const homepagePath = `/${serviceName}${variantPath}`;
urlsToExcludeFromAmpTests.push(homepagePath);

2. Have a named filter to exclude the homepage path - again it needs the correct service name from ☝️

const { variant, serviceName } = config[service]; 
const variantPath = variant === 'default' ? '' : `/${variant}`;
const isHomePagePath = path, serviceName => path === `/${serviceName}${variantPath}`;

paths.filter(path => !isHomePagePath(path, serviceName))

[amoore108]

Either of those look good? Just so long as that variant is captured correctly as you say.

The urls to exclude array is already in use, so maybe that option?

Is that ok with you @louisearchibald ?

[karinathomasbbc]

Yeah my preference was the urlsToExcludeFromAmpTests array, because it is more readable than array filtering!

[louisearchibald]

Yep @amoore108 @karinathomasbbc , will make some changes and push up 👍

[amoore108]

Great stuff, thanks both 🙏🏻

[amoore108]

Just thinking, this logic may be problematic:
if (!urlsToExcludeFromAmpTests.some(url => path.includes(url)))

The path.includes(url) will capture all the URLs for the test suite, e.g. /thai, /thai/articles/xxxxx etc because it includes the string /thai, so it won't just skip the homepage route.

[karinathomasbbc]

Ah... so it would. Maybe the other option then?

[amoore108]

Thanks for the amendments. I tested locally and all looks good 👍

[karinathomasbbc]

Nice work, thanks for this!

[karinathomasbbc]

🎏 What happens when we have serbian / uzbek / zhongwen configured?

[amoore108]

We'll need to tackle that if/when it happens 😅 Lou did point this out during our discussions on a solution, so we'll need some extra logic to cater for the serbianCyr naming etc.

[karinathomasbbc]

Yeah I checked the CD pipeline and scheduled E2Es and none of the variant services are configured in the cypress settings file for these cookie banner tests. If we were to add them, then we would need to fix it then, but don't need to worry about it at the moment. (We've had to workaround this annoying configuration many times in the Cypress tests 🙄)