WSTEAMA-1572: Remove "hashedId" to match sign-in status #12362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA [WSTEAMA-1572]
Overall changes
Removes the value,
hashedId
, from Reverb config since it sets the user ID instead of the visitor ID.Background Context
Following this conversation, we investigated the usage of values set in the
user
object of theReverb configuration. The investigation revealed that the
hashedId
we've been passing in the Reverbconfiguration for the purpose of setting the visitor ID was incorrect. This is because the
hashedId
whichwe pass to Reverb via the function,
getHashedId
, is meant to track users instead of visitors.Through conversations with the Reverb, we've established that Reverb manages the generation and
persistence of the visitor ID via the
atuserid
cookie. The values stored inatuserid
is then reportedto Piano via the query parameter,
idclient
. We therefore don't need to manage theatuserid
cookie in Simorgh once we transition to Reverb.
The Reverb team recommended that we should retain the user object even though our audience
is not signed in and set the function,
getHashedId
to returnnull
.See WSTEAMA-1572 for link to Slack thread
Code changes
hashedId
from the Reverb page view beacon configuration.hashedId
from the Reverb component tracking beacon configuration.Testing
idclient
query parameter.Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines