Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSTEAM1-1588: Bug Fix - Media Player blocking content in no CSS mode #12352

Closed
wants to merge 5 commits into from

Conversation

Isabella-Mitchell
Copy link
Contributor

@Isabella-Mitchell Isabella-Mitchell commented Jan 30, 2025

Resolves JIRA N/A

Possible solution to WSTEAM1-1588. See more in Paper Doc.

Overall changes

Adds an element below media player. This "pushes down" the content currently being blocked.

Code changes

  • In instances without a placeholder, adds an SVG below media container if mediaType is 'audio_video' or 'video'
  • Uses "display:none" to hide SVG with CSS. (So will only show if CSS is disabled)

Testing

"Pushes down" content

Should have no affect (not video/ audio_video content)

Will have no affect (uses placeholder)

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@Isabella-Mitchell Isabella-Mitchell changed the title Wsteam1 1588 media no css WSTEAM1-1588: Bug Fix - Media Player blocking content in no CSS mode Feb 3, 2025
@Isabella-Mitchell
Copy link
Contributor Author

Closing this PR since we've identified this bug is specific to the Web Developer extension on Chrome. It does not occur when CSS is fully removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant