Lite Site: Remove data-react-helmet="true" attributes from all tags within the html <head> tag
#12350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karinathomasbbc
commented
Jan 31, 2025
| @@ -31,7 +31,7 @@ import { | |||
| import parseAvRoute from '../parseAvRoute'; | |||
|
|
|||
| const removeLeadingSlash = (path: string) => path?.replace(/^\/+/g, ''); | |||
| const removeAmp = (path: string) => path.split('.')[0]; | |||
| const removeSuffix = (path: string) => path.split('.')[0]; | |||
There was a problem hiding this comment.
Should this perhaps be renamed to removePlatform instead?
karinathomasbbc
commented
Jan 31, 2025
| @@ -257,9 +257,12 @@ const constructPageFetchUrl = ({ | |||
| const variantPath = variant ? `/${variant}` : ''; | |||
| const host = `http://${process.env.HOSTNAME || 'localhost'}`; | |||
| const port = process.env.PORT ? `:${process.env.PORT}` : ''; | |||
| // pathname is the ID of the Live page without /service/live/, and supports both Tipo & CPS IDs | |||
|
|
|||
| let liveId = id; | |||
There was a problem hiding this comment.
Do we need to add a comment here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall changes
Removes the data-react-helmet attribute from the HTML head, to reduce page weight
Code changes
Testing
On Firefox with cache disabled
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines