Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSTEAMA-1565 - Remove old route pattern matcher #12342

Merged
merged 18 commits into from
Jan 28, 2025

Conversation

louisearchibald
Copy link
Contributor

@louisearchibald louisearchibald commented Jan 28, 2025

Resolves JIRA [1565]

Overall changes

Clean-up PR to remove a route matcher and that follows a URL pattern we are no longer using.

Code changes

  • Removes the old pattern route matcher.
  • Removes any references to the deleted route matcher.
  • Removes old batch of topic tests which previously tested the old route.
  • Renames the new route matcher from getVariantTopicPageRegex to be getTopicPageRegex. (same name as the old name, but with URL pattern updated).
  • Updates all references to new route matcher with the updated name.
  • Removes old snapshots.

@louisearchibald louisearchibald self-assigned this Jan 28, 2025
@louisearchibald louisearchibald marked this pull request as ready for review January 28, 2025 10:14
@amoore108 amoore108 merged commit c3ceca4 into latest Jan 28, 2025
11 checks passed
@amoore108 amoore108 deleted the WSTEAMA-1565-remove-old-route-pattern-matcher branch January 28, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants