-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate how we incorporate onward journeys into the navigation #12254
Draft
LilyL0u
wants to merge
21
commits into
latest
Choose a base branch
from
WSTEAMA-1522-investigate-incorporating-ojs-into-nav
base: latest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 5 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ac13f6c
top stories showing on page
LilyL0u 184d4e8
most read data in component and OJ is complementary aside
LilyL0u 63035bc
fix broken other scrollable promo
LilyL0u f6ae1e3
use switch case
LilyL0u 212bb01
do not show on PGLs or TC2s
LilyL0u 6a1fcd5
do not show component over 1007px
LilyL0u 613642b
storybook components and fixture data for storybook
LilyL0u f7df9cd
ariaLabelledBy must be different from other most read or top stories …
LilyL0u 5bac80c
snapshots and check for presence of most read data before trying to a…
LilyL0u c1260da
translations for titles
LilyL0u c51eb0b
add fallback title for if no translations
LilyL0u 81e5bc6
scrollable promo tests
LilyL0u 102c169
snapshots with translation
LilyL0u 37004c5
some top stories do not have same headline structure
LilyL0u 79ba241
comments on getting variant from optimizely
LilyL0u c602b5c
renames, refactors
LilyL0u f0dfaea
else if needed or title fall through
LilyL0u 7a287c7
default value for pathOr in proper place
LilyL0u f525490
add hyphen to title so it isn't the same as other oj component
LilyL0u 4d01e13
check for presence of any oj data needed before rendering
LilyL0u 42f60b8
check nothing has broken with control variant none
LilyL0u File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want the OJs to render on TC2 pages?