-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move AMP iframe and Psammead components to MediaLoader #11994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoore108
commented
Sep 27, 2024
Comment on lines
255
to
257
styles.figure(embedded), | ||
setAspectRatio && [ | ||
orientation === 'portrait' && styles.portraitFigure(embedded), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to pass in embedded
into the stylesheets because AMP will iframe and ultimately render this component. So some of the styles should only apply to the outer figure
outside of the iframe and not the inner figure
inside the iframe, and vice versa 🫠
karinathomasbbc
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall changes
figure
element. This ensures that all content within thefigure
element flows with the aspect-ratio that is setAVPlayer
andMediaPlayer
components, as well as Psammead components no longer usedTesting
?renderer_env=<environment>
to the end of theampIframeUrl
variable:simorgh/src/app/components/MediaLoader/index.tsx
Line 284 in 994be3c
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines