Merge branch 'latest' into WORLDSERVICE-79-enable-reverb-on-live-pidgin

bbc · Feb 7, 2025 · c472725 · c472725
2 parents 4b81e17 + b2fc92c
commit c472725
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 1 deletion.
diff --git a/cypress/e2e/pages/articles/index.cy.js b/cypress/e2e/pages/articles/index.cy.js
@@ -195,7 +195,7 @@ const nonSmokeCanonicalTestSuites = [
   },
 ];
 
-const canonicalTestSuites = Cypress.env.SMOKE
+const canonicalTestSuites = Cypress.env('SMOKE')
   ? smokeCanonicalTestSuites
   : nonSmokeCanonicalTestSuites;
 

diff --git a/src/app/components/MediaLoader/types.ts b/src/app/components/MediaLoader/types.ts
@@ -20,6 +20,7 @@ export type PlayerConfig = {
   insideIframe?: boolean;
   embeddedOffsite?: boolean;
   externalEmbedUrl?: string;
+  superResponsive?: boolean;
   statsObject: {
     clipPID?: string | null;
     episodePID?: string | null;

diff --git a/src/app/components/MediaLoader/utils/buildSettings.test.ts b/src/app/components/MediaLoader/utils/buildSettings.test.ts
@@ -74,6 +74,7 @@ describe('buildSettings', () => {
           appName: 'news-serbian',
           appType: 'responsive',
           counterName: 'live_coverage.testID.page',
+          superResponsive: true,
           playlistObject: {
             title:
               "BBC launch trailer for We Know Our Place women's sport campaign",
@@ -158,6 +159,7 @@ describe('buildSettings', () => {
           appName: 'news-serbian',
           appType: 'responsive',
           counterName: 'live_coverage.testID.page',
+          superResponsive: true,
           playlistObject: {
             title: 'Five things ants can teach us about management',
             summary: 'This is a caption!',
@@ -224,6 +226,7 @@ describe('buildSettings', () => {
           appName: 'news-serbian',
           appType: 'responsive',
           counterName: 'live_coverage.testID.page',
+          superResponsive: true,
           playlistObject: {
             title: 'Five things ants can teach us about management',
             summary: 'This is a caption!',
@@ -292,6 +295,7 @@ describe('buildSettings', () => {
         appName: 'news-serbian',
         appType: 'responsive',
         counterName: 'live_coverage.testID.page',
+        superResponsive: true,
         externalEmbedUrl:
           'https://www.bbc.com/serbian/lat/av-embeds/srbija-68707945/vpid/bbc_arabic_tv',
         playlistObject: {
@@ -349,6 +353,7 @@ describe('buildSettings', () => {
           appName: 'news-arabic',
           appType: 'responsive',
           counterName: 'arabic.multimedia.2013.12.131208_iraq_blast_.page',
+          superResponsive: true,
           playlistObject: {
             title: 'Legacy Media Page Title',
             holdingImageURL:
@@ -700,6 +705,7 @@ describe('buildSettings', () => {
           autoplay: false,
           appName: 'news-hindi',
           counterName: 'hindi.bbc_hindi_tv.tv.w172zm8920nck2z.page',
+          superResponsive: true,
           statsObject: {
             destination: 'WS_NEWS_LANGUAGES',
             producer: 'HINDI',
@@ -874,6 +880,7 @@ describe('buildSettings', () => {
           appType: 'responsive',
           autoplay: false,
           counterName: 'hausa.bbc_hausa_radio.liveradio.page',
+          superResponsive: true,
           playlistObject: {
             items: [
               {
@@ -956,6 +963,7 @@ describe('buildSettings', () => {
           autoplay: false,
           appName: 'news-afrique',
           counterName: 'afrique.bbc_afrique_radio.w172zn0kxd65h3g.page',
+          superResponsive: true,
           statsObject: {
             destination: 'WS_NEWS_LANGUAGES',
             producer: 'AFRIQUE',
@@ -1081,6 +1089,7 @@ describe('buildSettings', () => {
           autoplay: false,
           counterName: 'live_coverage.c7dkx155e626t.page',
           enableToucan: true,
+          superResponsive: true,
           playlistObject: {
             holdingImageURL:
               'https://ichef.bbci.co.uk/images/ic/$recipe/p0k31t4d.jpg',
@@ -1180,6 +1189,7 @@ describe('buildSettings', () => {
           autoplay: false,
           counterName: 'live_coverage.cvp5r6m6mgpt.page',
           enableToucan: true,
+          superResponsive: true,
           playlistObject: {
             holdingImageURL:
               'https://ichef.bbci.co.uk/images/ic/$recipe/p08b23t4.png',

diff --git a/src/app/components/MediaLoader/utils/buildSettings.ts b/src/app/components/MediaLoader/utils/buildSettings.ts
@@ -54,6 +54,7 @@ const buildSettings = ({
       subtitles: { enabled: true, defaultOn: true },
       fullscreen: { enabled: true },
     },
+    ...(!embedded && { superResponsive: true }),
     ...(counterName && { counterName }),
     ...(isTestRequested() && { mediator: { host: 'open.test.bbc.co.uk' } }),
     statsObject: {