Simplify amp iframe baseUrl logic

bbc · Sep 17, 2024 · 4b84691 · 4b84691
1 parent d9c3bce
commit 4b84691
Showing 1 changed file with 1 addition and 16 deletions.
diff --git a/src/app/components/MediaLoader/utils/urlConstructors.ts b/src/app/components/MediaLoader/utils/urlConstructors.ts
@@ -1,4 +1,3 @@
-import { getEnvConfig } from '#app/lib/utilities/getEnvConfig';
 import isLive from '#app/lib/utilities/isLive';
 import parseAvRoute from '#app/routes/utils/parseAvRoute';
 
@@ -7,20 +6,6 @@ const TEST_BASE_URL = 'https://www.test.bbc.com';
 
 const LIVE_AMP_URL = 'https://web-cdn.api.bbci.co.uk';
 const TEST_AMP_URL = 'https://web-cdn.test.api.bbci.co.uk';
-const DEV_AMP_URL = TEST_AMP_URL;
-
-const isDev = () => getEnvConfig().SIMORGH_APP_ENV === 'local';
-
-const getAmpBaseUrl = () => {
-  switch (true) {
-    case isLive():
-      return LIVE_AMP_URL;
-    case isDev():
-      return DEV_AMP_URL;
-    default:
-      return TEST_AMP_URL;
-  }
-};
 
 type FuncProps = {
   id: string | null;
@@ -33,7 +18,7 @@ export const getAmpIframeUrl = ({ id, versionID, lang }: FuncProps) => {
 
   const { platform, service, variant, assetId } = parseAvRoute(id);
 
-  const ampBaseUrl = getAmpBaseUrl();
+  const ampBaseUrl = isLive() ? LIVE_AMP_URL : TEST_AMP_URL;
 
   if (platform === 'cps') {
     return `${ampBaseUrl}/ws/av-embeds/cps/${service}${variant ? `/${variant}` : ''}/${assetId}${versionID ? `/${versionID}` : ''}${lang ? `/${lang}` : ''}/amp`;