Revert "Add #'projectile-track-known-projects-find-file-hook to 'buff…

[codeasone]

Responding to #1908

This reverts commit 3c92d28.

Addresses an apparent performance regression

• The commits are consistent with our contribution guidelines
• [-] You've added tests (if possible) to cover your change(s)
• All tests are passing (eldev test)
• The new code is not generating bytecode or M-x checkdoc warnings
• You've updated the changelog (if adding/changing user-visible functionality)
• You've updated the readme (if adding/changing user-visible functionality)

[jtamagnan]

Hi @bbatsov and @codeasone,

Sorry for not having taken a look at this and you needing to deal with it. I agree with reverting this change and I'm glad that its been reverted before projectile's next full release.

Although some packages properly declare buffers that they use as temporary such that the buffer-list-update-hook is not run, others like org-mode don't seem to do that - https://github.com/bzg/org-mode/blob/b6dbf8881076191e1351d7cd15e26547a2531fea/lisp/org-macs.el#L1193. Sadly it seems like the Emacs ecosystem isn't fully ready for buffer-list-update-hook to be used in this way, and although it "feels right" it simply isn't and it degrades user experience.

Again sorry that these issues came up and that you had to deal with them.

Best,
Jules

[bbatsov]

No worries. Changes typically take a long time in the world of Emacs and I guess that's OK.

[bbatsov]

Dropping here a link to #1895 and some extra context for the future #1895 (comment)