Skip to content

Harden property-based tests for mock and real ESMF compatibility - #20

Draft
bbakernoaa wants to merge 1 commit into
mainfrom
jules-2417613695634024600-6ebfbb22
Draft

Harden property-based tests for mock and real ESMF compatibility#20
bbakernoaa wants to merge 1 commit into
mainfrom
jules-2417613695634024600-6ebfbb22

Conversation

@bbakernoaa

Copy link
Copy Markdown
Owner

Adapted property-based tests in tests/test_property_based.py to be compatible with both mock and real ESMF backends. Corrected coordinates bounds check math in test_create_grid_like_properties by incorporating original half-resolution offsets. All tests now pass successfully under both mock and real esmpy environments.


PR created automatically by Jules for task 2417613695634024600 started by @bbakernoaa

This commit adapts property-based tests in `tests/test_property_based.py`
to support mock ESMF environments. When esmpy is mocked, regridding
assertions are adapted to match the single non-zero mapped weight output
instead of expecting real full-sphere regridding results. In addition,
the bounds check in `test_create_grid_like_properties` has been corrected
to include the template grid's half-resolution offset since center
coordinates differ from edge boundary extents. All 90 tests pass 100%.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant