Fix @build_bazel_rules_typescript//third_party/github.com/bazelbuild/…

…bazel/src/main/protobuf:worker_protocol.proto target in npm @bazel/typescript generated bazel workspace Closes #404 PiperOrigin-RevId: 232380639
bazelbuild · Feb 4, 2019 · f9b7c34 · f9b7c34
1 parent 2c5e4a8
commit f9b7c34
Show file tree

Hide file tree

Showing 6 changed files with 27 additions and 0 deletions.
diff --git a/internal/e2e/npm_packages/typescript_2.7/BUILD.bazel b/internal/e2e/npm_packages/typescript_2.7/BUILD.bazel
@@ -34,6 +34,10 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
+    data = [
+        # Verify that worker_protocol.proto can be referenced as a target in the generated npm bazel workspace
+        "@build_bazel_rules_typescript//third_party/github.com/bazelbuild/bazel/src/main/protobuf:worker_protocol.proto",
+    ],
     deps = [
         ":test_lib",
         "@npm//jasmine",

diff --git a/internal/e2e/npm_packages/typescript_2.8/BUILD.bazel b/internal/e2e/npm_packages/typescript_2.8/BUILD.bazel
@@ -34,6 +34,10 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
+    data = [
+        # Verify that worker_protocol.proto can be referenced as a target in the generated npm bazel workspace
+        "@build_bazel_rules_typescript//third_party/github.com/bazelbuild/bazel/src/main/protobuf:worker_protocol.proto",
+    ],
     deps = [
         ":test_lib",
         "@npm//jasmine",

diff --git a/internal/e2e/npm_packages/typescript_2.9/BUILD.bazel b/internal/e2e/npm_packages/typescript_2.9/BUILD.bazel
@@ -34,6 +34,10 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
+    data = [
+        # Verify that worker_protocol.proto can be referenced as a target in the generated npm bazel workspace
+        "@build_bazel_rules_typescript//third_party/github.com/bazelbuild/bazel/src/main/protobuf:worker_protocol.proto",
+    ],
     deps = [
         ":test_lib",
         "@npm//jasmine",

diff --git a/internal/e2e/npm_packages/typescript_3.0/BUILD.bazel b/internal/e2e/npm_packages/typescript_3.0/BUILD.bazel
@@ -34,6 +34,10 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
+    data = [
+        # Verify that worker_protocol.proto can be referenced as a target in the generated npm bazel workspace
+        "@build_bazel_rules_typescript//third_party/github.com/bazelbuild/bazel/src/main/protobuf:worker_protocol.proto",
+    ],
     deps = [
         ":test_lib",
         "@npm//jasmine",

diff --git a/internal/e2e/npm_packages/typescript_3.1/BUILD.bazel b/internal/e2e/npm_packages/typescript_3.1/BUILD.bazel
@@ -34,6 +34,10 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
+    data = [
+        # Verify that worker_protocol.proto can be referenced as a target in the generated npm bazel workspace
+        "@build_bazel_rules_typescript//third_party/github.com/bazelbuild/bazel/src/main/protobuf:worker_protocol.proto",
+    ],
     deps = [
         ":test_lib",
         "@npm//jasmine",

diff --git a/third_party/github.com/bazelbuild/bazel/src/main/protobuf/BUILD.bazel b/third_party/github.com/bazelbuild/bazel/src/main/protobuf/BUILD.bazel
@@ -1,13 +1,18 @@
+# BEGIN-DEV-ONLY
+# Parts of this BUILD file only necessary when building within the bazelbuild/rules_typescript repo.
+# The generated `@bazel/typescript` npm package contains a trimmed BUILD file using # DEV-ONLY fences.
 load("@io_bazel_rules_go//go:def.bzl", "go_library")
 load("@io_bazel_rules_go//proto:def.bzl", "go_proto_library")
 
 package(default_visibility = ["//:__pkg__"])
 
 licenses(["notice"])  # Apache 2.0
+# END-DEV-ONLY
 
 # Export the raw proto file so protobufjs can be used reflectively without codegen
 exports_files(["worker_protocol.proto"])
 
+# BEGIN-DEV-ONLY
 proto_library(
     name = "blaze_worker_proto",
     srcs = ["worker_protocol.proto"],
@@ -31,6 +36,8 @@ go_library(
 filegroup(
     name = "npm_package_assets",
     srcs = [
+        "BUILD.bazel",
         "worker_protocol.proto",
     ],
 )
+# END-DEV-ONLY