Filter out non-standard header extensions from module maps #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrymarino
reviewed
Sep 30, 2022
| @@ -93,7 +93,7 @@ def write_module_map( | |||
|
|
|||
| def _add_headers(*, headers, kind): | |||
| content.add_all( | |||
| headers, | |||
There was a problem hiding this comment.
Is this ending up being called in rules_swift ? I'd expect this to not be called - I wonder if there's been a regression in rules_swift - or it's not conditionally flipped off
|
Probably better fix via bazel-ios/rules_ios#603 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bazel-ios/rules_ios#562, I realized that the hmap and vfsoverlay files are passed as
headersonCcInfo.compilation_contextas a workaround for the lack of custom providers in the Java-side rules. As a result,rules_swiftattempts to add them to the modulemaps, which leads to failures.