Added tool for generating vscode debug tasks #3671
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
force-pushed
the
debug
branch
6 times, most recently
from
e90ac2a to
afad691
Compare
illicitonion
approved these changes
Oct 19, 2025
| .unwrap_or_else(|_| panic!("couldn't open {:?}", &launch_json_path)); | ||
|
|
||
| // Verify basic JSON structure | ||
| assert!(content.contains(r#""version": "0.2.0""#)); |
There was a problem hiding this comment.
I'd be tempted to actually parse the JSON here rather than doing string asserts, but also recognise going from 0 to non-0 dependencies is annoying
|
|
||
| /// Don't pretty print generated JSON | ||
| #[arg(long)] | ||
| no_pretty: bool, |
There was a problem hiding this comment.
Maybe pretty with default true, rather than default negation?
There was a problem hiding this comment.
Does clap support this?
tools/vscode/src/lib.rs
Outdated
| } | ||
|
|
||
| /// Query information about a specific target. | ||
| pub fn query_target_info(&mut self, target: &str) -> Result<TargetInfo> { |
There was a problem hiding this comment.
AFAICT this is unused?
I was going to ask why we need both this and find_rust_targets, but I suspect the answer is we don't?
There was a problem hiding this comment.
Good catch, deleted!
Co-authored-by: Daniel Wagner-Hall <[email protected]>
Co-authored-by: Daniel Wagner-Hall <[email protected]>
Co-authored-by: Daniel Wagner-Hall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces
//tools/vscodewhich includes tools for vscode integrations. Separate from//tools/rust_analyzer, this new package includes agen_launch_jsontarget which can be used to generate "Run and Debug" tasks forrust_binaryandrust_testtargets.closes #370