Skip to content

Run browser tests with Safari on MacOS #3354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1101,9 +1101,8 @@ tasks:
test_flags: *aspects_flags
build_targets:
- "//..."
# TODO: https://github.com/bazelbuild/rules_rust/issues/3039
# test_targets:
# - "//..."
test_targets:
- "//..."
extensions_wasm_bindgen_macos:
platform: macos_arm64
name: Extensions wasm-bindgen
Expand All @@ -1114,9 +1113,8 @@ tasks:
test_flags: *aspects_flags
build_targets:
- "//..."
# TODO: https://github.com/bazelbuild/rules_rust/issues/3039
# test_targets:
# - "//..."
test_targets:
- "//..."
extensions_wasm_bindgen_windows:
platform: windows
name: Extensions wasm-bindgen
Expand Down
5 changes: 2 additions & 3 deletions .bcr/extensions/wasm_bindgen/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,5 @@ bcr_test_module_macos:
bazel: ${{ bazel }}
shell_commands:
- "bash ./test/bazelci_unix_setup.sh"
# TODO: https://github.com/bazelbuild/rules_rust/issues/3039
# test_targets:
# - "//..."
test_targets:
- "//..."
1 change: 1 addition & 0 deletions extensions/wasm_bindgen/.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ common --experimental_cc_shared_library

# Default linux to run firefox
build:linux --test_browser=firefox
build:macos --test_browser=safari

# Enable use of the nightly toolchains.
build:nightly --@rules_rust//rust/toolchain/channel=nightly
Expand Down