add a stopgap experimental_use_whole_archive_for_native_deps attribute #1269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scentini
requested changes
Apr 19, 2022
|
After chatting 1:1, it appears currently there's no good way to test this (the new feature requires a recent nightly, we don't have a nightly build bot setup yet, and we don't have a fully unit-test style test framework that doesn't attempt to always analyse the target_under_test-s). Will work on improvements to the test infra have some form of rustc nightly bot coverage in the future. |
scentini
approved these changes
Apr 20, 2022
goffrie
pushed a commit
to goffrie/rules_rust
that referenced
this pull request
Apr 21, 2022
bazelbuild#1269) This adds a new stopgap attribute enabling us to fall back to the old rustc behavior wrt whole-archive handling, see bazelbuild#1268.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new stopgap attribute enabling us to fall back to the old rustc behavior wrt whole-archive handling, see #1268.