Update rules_android to 0.5.1 #1205
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
requested review from
ahumesky,
cgruber,
nkoroste and
restingbull
as code owners
restingbull
approved these changes
Aug 12, 2024
| sha256 = versions.ANDROID.SHA, | ||
| strip_prefix = "rules_android-%s" % versions.ANDROID.VERSION, | ||
| urls = ["https://github.com/bazelbuild/rules_android/archive/v%s.zip" % versions.ANDROID.VERSION], | ||
| sha256 = versions.ANDROID.sha256, |
Collaborator
There was a problem hiding this comment.
You can use `versions.use_repository(name = "rules_android", rule=http_archive, version =version.ANDROID)
Collaborator
There was a problem hiding this comment.
Can you check if this works? It doesn't have the .bazelrc changes the others do.
Collaborator
Author
|
Related bazel-contrib/rules_jvm_external#1215, might be worth while holding off on this PR a bit longer to sort out the |
Collaborator
Author
|
All of the native providers are being moved into Starlark which will unblock this PR bazelbuild/rules_android@ee0f53d |
Collaborator
|
See bazelbuild/rules_android#256 for updates on the provider Starlark migration |
Bencodes
force-pushed
the
update-rules_android-to-0.5.1
branch
from
57d78f1 to
e342eba
Compare
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.