Skip to content

Conversation

@cerisier
Copy link
Contributor

@cerisier cerisier commented Oct 28, 2025

This was the default in Bazel before Starlarkification.

-D     When building a static library, set archive contents' user ids, group ids, dates, and file modes to reasonable defaults. This allows libraries created with identical input to be identical to
       each other, regardless of time of day, user, group, umask, and other aspects of the environment.

This was the default in Bazel before Starlarkification.
Copy link
Member

@keith keith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. note that this wasn't about starlarkification, it's that the apple toolchain moved to here https://github.com/bazelbuild/apple_support/blob/d10e819ba4473be553db7247f18da3b9fb11bc3e/crosstool/cc_toolchain_config.bzl#L622-L629, it is recommended you use that instead of the toolchains here when targeting apple platfroms. there are some much more subtle hermeticity issues handled in that repo that aren't handled here

@cerisier
Copy link
Contributor Author

Sure enough! The only reason i'm bring those is because a project I'm working on was using rules_cc instead of apple_support and they didn't want to introduce any other dependency...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants