Allow BCR PR reviewer to merge PRs #2176
Merged
+22
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fweikert
approved these changes
Feb 7, 2025
fmeum
reviewed
Feb 10, 2025
| owner, | ||
| repo, | ||
| issue_number: prNumber, | ||
| labels: ['auto-merged'], |
There was a problem hiding this comment.
Can't the PR author remove this label?
There was a problem hiding this comment.
The PR author usually don't have permission to modify labels except they are BCR maintainers, right?
There was a problem hiding this comment.
I wasn't sure, but if that's the case, then this looks good!
There was a problem hiding this comment.
Yeah, I double check, this is true ;)
meteorcloudy
added a commit
to bazelbuild/bazel-central-registry
that referenced
this pull request
Feb 10, 2025
fweikert
pushed a commit
to fweikert/continuous-integration
that referenced
this pull request
Mar 27, 2025
With all the presubmit checks enhanced, it should now be safe to allow the BCR presubmit bot to merge PRs. Merged PRs will be assigned an "auto-merged" label for post-audit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With all the presubmit checks enhanced, it should now be safe to allow the BCR presubmit bot to merge PRs.
Merged PRs will be assigned an "auto-merged" label for post-audit.