Raise default --watchfs event limit
#23682
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-Rules-CPP
By default, the JDK only reports up to 500 events per `WatchKey` (and thus, per directory). This can be too low in large repos. RELNOTES: The default limit on the number of `--watchfs` file events per directory has been raised to 10,000 (from 500). If needed, it can be increased further via `--host_jvm_args=-Djdk.nio.file.WatchService.maxEventsPerPoll=N`.
fmeum
force-pushed
the
watchfs-limit
branch
from
2047c9d
to
c018f9c
Compare
|
Do you have an idea why the test is failing on Linux on CI? |
|
It's failing because it requires JDK 23, but my update has been rolled back as the released version of async-profiler isn't compatible with the new JDK yet. I could set up a from-source build for async-profiler rather than getting it from Maven. This would potentially also make the Bazel binary smaller as it would no longer ship the native lib for all architectures. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the JDK only reports up to 500 events per
WatchKey(and thus, per directory). This can be too low in large repos.Work towards #13226
RELNOTES: On Linux, the default limit on the number of
--watchfsfile events per directory has been raised to 10,000 (from 500). If needed, it can be increased further via--host_jvm_args=-Djdk.nio.file.WatchService.maxEventsPerPoll=<limit>.