-
-
Notifications
You must be signed in to change notification settings - Fork 577
feat: make bootstrap=script default for linux #2760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: make bootstrap=script default for linux #2760
Conversation
3b827f4
to
902ca8a
Compare
902ca8a
to
0fb8f52
Compare
Hrm. CI flagged an issue relating to the runtime-env toolchain: it doesn't respect the virtual env. This is because the There's another CI failure relating to compile_pip_requirements, but I haven't had a chance to look yet. |
note to self:
|
Ok, so what I've figured out is:
(1) and (2) mean, in order to use py3.9 with runtime-venv toolchain, the only way to make it even see the venv is to create it at runtime with the typical symlink. This would also solve (3) (symlink lib/python3.11 to python3.10; technically wrong, but matches historical behavior); I can think of some alternatives for (3) that might work right now (PYTHONPATH, addsitedir(), or sys.path setup in stage2), but in order to have a normally functioning venv site-packages dir, we have to create lib/pythonX.Y matching the current runtime version. Anyways, what I'm thinking is to add something to the toolchain definition that says "recreate the venv at runtime", and then the runtime env toolchain sets this. We already have a flag for this due to rules_pkg not handling raw symlinks. I think having a "create venv at runtime" thing is gonna be a fact of life for awhile, at least until 3.11 is the minimum supported version. |
…into feat.default.bootstrap.script
wip
DO NOT MERGE: