-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vim4: upgrade kernel and gpu #13397
base: master
Are you sure you want to change the base?
vim4: upgrade kernel and gpu #13397
Conversation
Notable major changes * Upgrade to maintained Kernel version 5.15.x * Upgrade Mali GPU (r44) * Upgrade Firmware files * VIM4N board support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks fine. If you can outline the benefits these updates bring, that will be helpful. Ideally it should be added to the changelog too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this approach seems rather odd, can you explain why you have to do it this way?
does the kernel module not load these at boot? can we change the kernel configs for the drivers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent was to load the video ucode as early as possible to make the hardware decoders happy which get loaded later in the S06modprobe. Converting the inserted modules in the script to buitin forces other modules to be builtin as well. It seems some of the modules cannot be builtin because they need to be loaded in certain order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is forcing to preload a lot of modules, why is this necessary?
can you not change the kernel module to load in the kernel config if they're essential for booting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous modules.conf was based on the board vendor's module.conf. This was to keep it consistent with that strategy.
However it in my TODO list to start fine tuning this list and also the builtin ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you could, it seems excessive especially considering some should autoload when needed accordingly. it can be a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an unusual method across these extra rtl* drivers. can you explain why they're necessary and done this way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rtl* drivers were built for a vanilla kernel but the board vendor backported some of the net functions to this kernel. This was causing build errors. It was cleaner to just override LINUX version for this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not make this a package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was deliberating whether to convert this to a package as done in buildroot/linux/Config.ext.in but instead followed the linux-ext-rk3588.mk method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would rather not do something hacky. please convert to a proper package please. it won't take much to change it.
The previous kernel version is unmaintained and abandoned by the vendor. I do not see any big jump in performance however it does bring in new mali library and hardware decoders. I hope the hardware decoders along with optee should help Kodi for DRM contents(fingers crossed). |
Notable major changes