fix(core): preserve agent source through note materialization - #1505
Merged
Merged
Conversation
Signed-off-by: phernandez <paul@basicmachines.co>
phernandez
marked this pull request as ready for review
September 8, 2026 00:12
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloud's managed agents accept notes with
source=agent_runtime. The materialization payload currently rejects that source, leaving an accepted note at DB version 2 while Tigris remains at version 1. This was observed in the real webhook/Gateway/MCP acceptance run for basicmachines-co/basic-memory-cloud#2003.Add
agent_runtimeto the shared source vocabulary so queue payloads and object metadata preserve the managed origin. This lets Cloud suppress recursive agent dispatch without preventing materialization.Validation: the new payload-to-object-provenance regression failed with the observed validation error before the change; it and five materialization matching tests pass after it. Ruff and the full
uv run --extra milvus ty check src tests test-intpass. The initialjust fast-checkreached type checking but lacked the optional Milvus dependency; the complete type check passed once that dependency was supplied. Cloud's live materialization rerun is pending the dependency update.