Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix bugs in fixed result #750

Merged
merged 2 commits into from
Oct 30, 2024
Merged

BUG: Fix bugs in fixed result #750

merged 2 commits into from
Oct 30, 2024

Conversation

bashtage
Copy link
Owner

Systematically find an fix bugs that affect fixed results

closes #749

@pep8speaks
Copy link

pep8speaks commented Oct 29, 2024

Hello @bashtage! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-10-30 16:05:30 UTC

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 64.04494% with 32 lines in your changes missing coverage. Please review.

Project coverage is 93.35%. Comparing base (47e796f) to head (779bf28).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
arch/tests/univariate/test_mean.py 59.45% 30 Missing ⚠️
arch/univariate/volatility.py 75.00% 1 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (47e796f) and HEAD (779bf28). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (47e796f) HEAD (779bf28)
12 4
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
- Coverage   99.52%   93.35%   -6.18%     
==========================================
  Files          74       74              
  Lines       15463    15536      +73     
  Branches     1270     1273       +3     
==========================================
- Hits        15389    14503     -886     
- Misses         50     1003     +953     
- Partials       24       30       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bashtage bashtage force-pushed the fixed-result-bugs branch 4 times, most recently from ff7524e to 52423a1 Compare October 30, 2024 13:52
Systematically find an fix bugs that affect fixed results

closes #749
Mark high dimensional tests as slow
@bashtage bashtage merged commit c94198e into main Oct 30, 2024
3 of 24 checks passed
@bashtage bashtage deleted the fixed-result-bugs branch October 30, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARX with exogenous variable forecasts residual variance is not as expected
2 participants