fix: guard HF_TOKEN env assignment against None when secret is not configured#576
Open
Dev-X25874 wants to merge 3 commits into
Open
fix: guard HF_TOKEN env assignment against None when secret is not configured#576Dev-X25874 wants to merge 3 commits into
Dev-X25874 wants to merge 3 commits into
Conversation
…one to fix TypeError on missing secret
…rror on missing secret
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This crashes the model at construction time — before
load()is ever called —with a confusing error unrelated to the actual missing configuration.
How
Wrap each assignment in a
if self.hf_secret_token:guard, matching the patternalready used correctly in
flux.1-dev-trt-b200/model/model.py,ngram-speculator/truss/model/model.py, andmidnight/model/model.py.Testing
The fix is a one-line guard per file. No functional change for deployments that
do supply
hf_access_token; deployments against public models without the secretconfigured will now load successfully instead of crashing.