Skip to content

Adding vllm speculative decoding example#317

Open
htrivedi99 wants to merge 2 commits into
mainfrom
het/vllm-spec-dec
Open

Adding vllm speculative decoding example#317
htrivedi99 wants to merge 2 commits into
mainfrom
het/vllm-spec-dec

Conversation

@htrivedi99

Copy link
Copy Markdown
Contributor

No description provided.

@htrivedi99 htrivedi99 requested review from bolasim and vshulman July 1, 2024 21:00
Comment on lines +1 to +3
base_image:
image: nvcr.io/nvidia/pytorch:23.11-py3
python_executable_path: /usr/bin/python3

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just cuious why we need this base image? Can you add a cooment?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this base image the build does not succeed. The baseten base image does not have nvcc, which is required for the developer build of vLLM.

Comment thread vllm-speculative-decoding/config.yaml Outdated
tensor_parallel: 1
max_num_seqs: 16
model_name: vLLM Speculative Decoding
python_version: py310

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop python version if using base image

python_executable_path: /usr/bin/python3
build_commands: []
environment_variables:
HF_TOKEN: ""

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why here over secrets?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vLLM reads only this specific environment variable for the access token. It doesn't work with secrets

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants